This repository was archived by the owner on Dec 16, 2018. It is now read-only.
Add Dockerized version #22
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmackinnon
approved these changes
Dec 11, 2018
rmackinnon
left a comment
rmackinnon
left a comment
There was a problem hiding this comment.
A review of the changes requested all look good, pretty minor stuff. Thank you for taking the time to put together a PR. I'm only a person that's been watching this project, but as a python guy this is a pretty straight forward API endpoint update.
Owner
|
Closing this PR since I'm no longer maintaining this project and will be archiving it soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the changes made by @zecoj, while also adding a Docker version and significantly adjusting the README file.
Additionally, I've built and pushed the Docker image to the Docker Hub, allowing people to pull it in and use it from there. The relevant command to do so has also been added to the README.