refactor: String column like % can rewrite to true #18263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TCeason
changed the title
github-actions
bot
added
the
pr-refactor
TCeason
force-pushed
the
like_%
branch
2 times, most recently
from
574c677 to
e5ad211
Compare
sundy-li
reviewed
Jun 27, 2025
| insert into t1 values('c',parse_json('[1,2,3,["a","b","c"],{"k":"v"}]'), 1),('c1',parse_json('[1,2,3,["a","b","c"],{"k":"v1"}]'), 2) | ||
|
|
||
| query T | ||
| explain select c from t1 where c like '%' |
There was a problem hiding this comment.
why not make it into domain cal for function like.
There was a problem hiding this comment.
Oh, that's exactly the case. Implementing a function is somewhat superfluous. It is possible to directly return a FunctionDomain::Domain(ALL_TRUE_DOMAIN)
TCeason
changed the title
sundy-li
approved these changes
Jun 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
In Snowflake :
explain select * from t where id=1 or c like '%' the like expr will rewrite to
((OCTET_LENGTH(T.C)) >= 0)However, I think that if the column type is string/variant and not null, we can return true directly.
Tests
Type of change
This change is