-
Notifications
You must be signed in to change notification settings - Fork 112
direct: Add support for secret scopes #3886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
10 failing tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newly added tests give more than enough coverage for this. (see basic test)
| Local = true | ||
| Cloud = false | ||
| RecordRequests = true | ||
| Local = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only run it on cloud because there's ordering issues in the permissions returned by GET that are not worth dealing with (because of the different user names, there is no stable sort).
|
|
||
| t.Run(resourceName+"_local", func(t *testing.T) { | ||
| validateFields(t, adapter.InputConfigType(), adapter.fieldTriggersLocal) | ||
| validateFields(t, adapter.StateType(), adapter.fieldTriggersLocal) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Field triggers apply to the output of PrepareState, not the input.
Changes
Adds direct deployment support for secret scopes with restructured acceptance tests and fixed local mock server.
Mock Server Fix
Fixed
libs/testserver/secret_scopes.goto automatically grant MANAGE permission to the creator when a scope is created, matching real Databricks behavior. This ensures local tests accurately simulate cloud behavior.Tests
New local and cloud acceptance tests.