-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix(ui/ingest): ingestion run report #13838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔴 Meticulous spotted visual differences in 3 of 1318 screens tested: view and approve differences detected. Meticulous evaluated ~8 hours of user flows against your PR. Last updated for commit d3b274e. This comment will update as new commits are pushed. |
Bundle ReportChanges will decrease total bundle size by 77 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Fix explain here loom.com/share/5b6dc75310c841c89f6e7e7502971aa2
Problems
In some cases our ingestion can emit more aspects than status aspect. But status aspect remains the most reliable way to tell what has been ingested
The total assets was using sink's total records which is not the same as total assets. So using some of numbers from each entity count's status to get total assets ingested.