Skip to content

fix(ui/ingest): ingestion run report #13838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 24, 2025

Conversation

anshbansal
Copy link
Collaborator

Fix explain here loom.com/share/5b6dc75310c841c89f6e7e7502971aa2

Problems

In some cases our ingestion can emit more aspects than status aspect. But status aspect remains the most reliable way to tell what has been ingested
The total assets was using sink's total records which is not the same as total assets. So using some of numbers from each entity count's status to get total assets ingested.

Copy link

alwaysmeticulous bot commented Jun 23, 2025

🔴 Meticulous spotted visual differences in 3 of 1318 screens tested: view and approve differences detected.

Meticulous evaluated ~8 hours of user flows against your PR.

Last updated for commit d3b274e. This comment will update as new commits are pushed.

@anshbansal anshbansal marked this pull request as ready for review June 23, 2025 16:24
Copy link

codecov bot commented Jun 23, 2025

Bundle Report

Changes will decrease total bundle size by 77 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 19.69MB -77 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js -77 bytes 16.06MB -0.0%

Files in assets/index-*.js:

  • ./src/app/ingestV2/source/utils.ts → Total Size: 7.38kB

Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jun 24, 2025
@anshbansal anshbansal merged commit f554679 into master Jun 24, 2025
32 of 33 checks passed
@anshbansal anshbansal deleted the ab-2025-jun-23-oss-ingestion-run-report branch June 24, 2025 13:49
kartikey-visa pushed a commit to kartikey-visa/datahub that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants