Skip to content

Conversation

@michaelsembwever
Copy link
Member

https://github.com/riptano/cndb/issues/15751

Port into main-5.0 commit 945b7a1

CNDB-15751: CNDB-15701: Forbid creating vector indexes if version is earlier than CA (#2071)

Creating vector indexes if version is earlier than CA would usually fail in the asynchronous build. This patch makes them fail synchronously at CREATE INDEX depending on the local index version. If the local node has the right version but any of the remotes doesn't, the failure will remain asynchronous.

BLOCKED on #2080 (for VersionSelectorTest.java)

…earlier than CA (#2071)

Creating vector indexes if version is earlier than CA would usually fail in the asynchronous build.
This patch makes them fail synchronously at CREATE INDEX depending on the local index version.
If the local node has the right version but any of the remotes doesn't, the failure will remain
asynchronous.
@github-actions
Copy link

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@djatnieks
Copy link

#2080 is approved now - this one is still marked as Draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants