Skip to content

Conversation

@michaelsembwever
Copy link
Member

https://github.com/riptano/cndb/issues/15897

Port into main-5.0 commit 8c93136

CNDB-15897: CNDB-7197: Added SAI_INDEX_METRICS_ENABLED to be able to enable/disable IndexMetrics (#2025)

...
We want to be able to enable/disable IndexMetrics

...
We add a flag to be able to do that -
`SAI_INDEX_METRICS_ENABLED("cassandra.sai.metrics.index.enabled", "true")`
Also, added some simple unit tests to test the new parameter.

…enable/disable IndexMetrics (#2025)

...
We want to be able to enable/disable IndexMetrics

...
We add a flag to be able to do that -
`SAI_INDEX_METRICS_ENABLED("cassandra.sai.metrics.index.enabled",
"true")`
Also, added some simple unit tests to test the new parameter.

---------

Co-authored-by: Andrés de la Peña <[email protected]>
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
4.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-2105 rejected by Butler


103 regressions found
See build details here


Found 103 new test failures

Showing only first 15 new test failures

Test Explanation Runs Upstream
test_cqlsh_completion.TestCqlshCompletion.test_complete_command_words (python3.8.jdk11.x86_64.no-cython.x86_64) REGRESSION 🔴🔴 0 / 15
test_cqlsh_completion.TestCqlshCompletion.test_complete_in_alter_keyspace (python3.8.jdk11.x86_64.no-cython.x86_64) REGRESSION 🔴🔴 0 / 15
test_cqlsh_completion.TestCqlshCompletion.test_complete_in_alter_type (python3.8.jdk11.x86_64.no-cython.x86_64) REGRESSION 🔴🔴 0 / 15
test_cqlsh_completion.TestCqlshCompletion.test_complete_in_create_columnfamily (python3.8.jdk11.x86_64.no-cython.x86_64) REGRESSION 🔴🔴 0 / 15
test_cqlsh_completion.TestCqlshCompletion.test_complete_in_create_table (python3.8.jdk11.x86_64.no-cython.x86_64) REGRESSION 🔴🔴 0 / 15
test_cqlsh_completion.TestCqlshCompletion.test_complete_in_create_user (python3.8.jdk11.x86_64.no-cython.x86_64) REGRESSION 🔴🔴 0 / 15
test_cqlsh_completion.TestCqlshCompletion.test_complete_in_delete (python3.8.jdk11.x86_64.no-cython.x86_64) REGRESSION 🔴🔴 0 / 15
test_cqlsh_completion.TestCqlshCompletion.test_complete_in_drop (python3.8.jdk11.x86_64.no-cython.x86_64) REGRESSION 🔴🔴 0 / 15
test_cqlsh_completion.TestCqlshCompletion.test_complete_in_drop_keyspace (python3.8.jdk11.x86_64.no-cython.x86_64) REGRESSION 🔴🔴 0 / 15
test_cqlsh_completion.TestCqlshCompletion.test_complete_in_drop_role (python3.8.jdk11.x86_64.no-cython.x86_64) REGRESSION 🔴🔴 0 / 15
test_cqlsh_completion.TestCqlshCompletion.test_complete_in_insert (python3.8.jdk11.x86_64.no-cython.x86_64) REGRESSION 🔴🔴 0 / 15
test_cqlsh_completion.TestCqlshCompletion.test_complete_in_revoke (python3.8.jdk11.x86_64.no-cython.x86_64) REGRESSION 🔴🔴 0 / 15
test_cqlsh_completion.TestCqlshCompletion.test_complete_in_select_order_by_ann_of (python3.8.jdk11.x86_64.no-cython.x86_64) REGRESSION 🔴🔴 0 / 15
test_cqlsh_completion.TestCqlshCompletion.test_complete_in_tracing (python3.8.jdk11.x86_64.no-cython.x86_64) REGRESSION 🔴🔴 0 / 15
test_cqlsh_completion.TestCqlshCompletion.test_complete_in_truncate (python3.8.jdk11.x86_64.no-cython.x86_64) REGRESSION 🔴🔴 0 / 15

No known test failures found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants