Skip to content

CNDB-15916: CNDB-11565: Prevents replaying commit log segments with invalid mutations from being replayed over and over #2111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main-5.0
Choose a base branch
from
Open

CNDB-15916: CNDB-11565: Prevents replaying commit log segments with invalid mutations from being replayed over and over #2111

wants to merge 1 commit into from

Conversation

@michaelsembwever
Copy link
Member

@michaelsembwever michaelsembwever commented Nov 6, 2025

https://github.com/riptano/cndb/issues/15916

Port into main-5.0 commit aa1eec9

CNDB-15916: CNDB-11565: Prevents replaying commit log segments with invalid mutations from being replayed over and over

Allow providing custom implementation for `CommitLogSegmentHandler`. This is useful for Cloud native Cassandra as it provides flexibility when ti comes to handling commit log segments.

Fixes https://github.com/riptano/cndb/issues/11565

@chatterjeesubarnadatastax @niksajakovljevic @michaelsembwever
CNDB-15916: CNDB-11565: Prevents replaying commit log segments with i…
ce2d38a 
…nvalid mutations from being replayed over and over (#1587)

Allow providing custom implementation for `CommitLogSegmentHandler`.
This is useful for Cloud native Cassandra as it provides flexibility
when ti comes to handling commit log segments.

Fixes riptano/cndb#11565

---------

Co-authored-by: niksa.jakovljevic <[email protected]>
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@djatnieks
Copy link

djatnieks commented Nov 8, 2025

Looks like this got a compilation error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatterjeesubarnadatastax chatterjeesubarnadatastax Awaiting requested review from chatterjeesubarnadatastax

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michaelsembwever @djatnieks @chatterjeesubarnadatastax