Fix refresh script for OSX #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
robb-romans
commented
Aug 23, 2018
robb-romans
commented
- Detect if we're on Docker for Mac (xhyve)
- Otherwise, use docker-machine (Docker Toolbox)
- Make IP variable more descriptive
- Add check for grunt executable
* Detect if we're on Docker for Mac (xhyve) * Otherwise, use docker-machine (Docker Toolbox) * Make IP variable more descriptive * Add check for grunt executable
nimbinatus
approved these changes
Aug 28, 2018
Member
nimbinatus
left a comment
nimbinatus
left a comment
There was a problem hiding this comment.
Just a minor note; not a blocker for merging.
script/refresh
Outdated
|
|
||
| DECONST=$(docker-machine ip ${DOCKER_MACHINE_NAME}) | ||
| if ! [[ -x "$(command -v grunt)" ]]; then | ||
| echo "Error: grunt command not found. Please install it." |
Member
There was a problem hiding this comment.
Minor note: I'd reword this error to be something like this to be a bit closer to the common shell error message. Might help folks who aren't too familiar with the terminal:
echo "Error: grunt: command not found. Install 'grunt' and retry."
Contributor
Author
|
@nimbinatus thanks. updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.