-
Notifications
You must be signed in to change notification settings - Fork 42
DLPX-86523 CIS: /home filesystem and mount options #756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
DLPX-86523 CIS: /home filesystem and mount options #756
Conversation
60315a7 to
2547134
Compare
4447b5d to
70aaee3
Compare
5a45f37 to
28406a7
Compare
28406a7 to
abd7103
Compare
abd7103 to
b8d8ec5
Compare
b8d8ec5 to
6497d9d
Compare
6497d9d to
bacfefb
Compare
58d854c to
fe722dd
Compare
fe722dd to
52199cc
Compare
52199cc to
c752b4f
Compare
c752b4f to
4c2f334
Compare
4c2f334 to
823162d
Compare
554ea59 to
b81c2e4
Compare
b81c2e4 to
7c5bcea
Compare
7c5bcea to
5ce66b3
Compare
b061620 to
7cc9bcf
Compare
a679462 to
66cea08
Compare
66cea08 to
4b2dc91
Compare
4b2dc91 to
ca8e5d1
Compare
a0a4d97 to
651f1b2
Compare
d348ab2 to
169d477
Compare
d3656ac to
c0e39b6
Compare
333c261 to
f91e276
Compare
f91e276 to
fee4071
Compare
fee4071 to
281c15c
Compare
Fixing the headers in the changed files. Incoprorating new comments from Seb Resolving comments from Seb on redundant nodev PR URL: https://www.github.com/delphix/appliance-build/pull/756
…tp-v2, disabling cache is the cleaner approach here
…tp-v2, disabling cache is the cleaner approach here- Change #2
…tp-v2, disabling cache is the cleaner approach here- Change #3
…thon package' woked in the removal of chache directorywith additional changes made.
e533769 to
5d365f5
Compare
| extra_args: "--no-cache-dir" | ||
| environment: | ||
| PIP_NO_CACHE_DIR: "yes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one is unnecessary, as the bootstrap ansible role doesn't run in the chroot. It's only run on the build server before the build starts.
| extra_args: "--no-cache-dir" | ||
| environment: | ||
| PIP_NO_CACHE_DIR: "yes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a comment here explaining why pip caching is bad at this stage of the build (because whatever files pip caches will end up in our production images, and we don't want that).
Problem
CIS is looking or a single home directory filesystem mounted at the
/homelocation, currently we have the home dataset is mounted on/export/homeDue to that we see the below issues in the CIS Report
Mounting the home dataset to `/home`.Solution
Testing Done
Build:
git ab-pre-push: appliance-build-orchestrator-pre-push/12448/ - ✅With current Build's AMI [ami-04ca90fb823528076], A fresh engine is created successfully, https://cis-dev.dlpxdc.co/ - 🟢
Scan Results:
Additionally we had to make changes to below repos to support this change
delphix-platform-> delphix-platformdlpx-app-gate-> dlpx-app-gateScan Reports before & after Change
Scan Report After Change
The report before this change (The initial report (before our change) is also present in : https://perforce.atlassian.net/browse/CP-9773)
Clarification
Additional Details:
Earlier review session I was suggested to remove lines
After removing these lines, we began seeing failures during first boot on a fresh engine:
split-precommit-dxostest-sr001.dlpxdc.co( Engine from previous build)Although /export/home is not mounted, the directory exists because of how the Linux build server is configured — its default home directory is /export/home. During the build process(appliance-build), AWS CLI creates cache files under /export/home/delphix/.cache, making the directory non-empty. This causes the cleanup logic to fail.
Example from the engine:
Because /export/home is not empty, the script exits with failure and causes the delphix-platform.service to stop.