only set cache-control headers for success response #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottcorgan
reviewed
Nov 30, 2016
| .end(done); | ||
| }); | ||
|
|
||
| it('sets cache control to 5 minutes? by default', function(done) { |
There was a problem hiding this comment.
Why did you delete these tests?
There was a problem hiding this comment.
Hmm, so if we don't set default cache-control header, what we should check here in the test? 🤔
There was a problem hiding this comment.
There's a default set to 5 minutes
There was a problem hiding this comment.
@scottcorgan It's intended to remove the default cache-headers for the same reason as #1 . The current code will override whatever is set inline which might not work as expected.
|
Thanks. Published as |
|
Thank you! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request trying to fix two thing:
2xxas we don't want to cache error response in most case.