This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Use Network.RealName instead of Network.Name during network check #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how the check to determine if a container is already connected to a network is done. It uses
Network.RealNameinstead ofNetwork.Name.A network defined inside
ServiceConfig.Networksusually have the following properties:projectname_networknamenetworknameThe network map returned by
Container.Networks()use the first form (projectname_networkname) as keys.Fix #480
Signed-off-by: Anthony Lapenna [email protected]