This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Fixed Vendor for sirupsen/logrus
#498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajnarwade
force-pushed
the
fix-logrus
branch
from
e4c4c58 to
4b3a519
Compare
Contributor
Author
|
cc @vdemeester |
vdemeester
suggested changes
Oct 13, 2017
Contributor
vdemeester
left a comment
vdemeester
left a comment
There was a problem hiding this comment.
You need to rm -fR vendor/github.com/Sirupsen to make sure it checks out the logrus lib with the lowercase. Once you do that, the build will fail and you will need to change the import path to github.com/sirupsen/logrus 😉
surajnarwade
force-pushed
the
fix-logrus
branch
2 times, most recently
from
6c11c7b to
8c6175b
Compare
surajnarwade
force-pushed
the
fix-logrus
branch
from
8c6175b to
e9a6e2e
Compare
vdemeester
force-pushed
the
fix-logrus
branch
from
e9a6e2e to
faae894
Compare
Contributor
|
@surajnarwade Updated your PR (by ammending the commit). Let's hope it doesn't fail 😓 |
vdemeester
force-pushed
the
fix-logrus
branch
3 times, most recently
from
a13d295 to
4a4bf14
Compare
Fixed namechange in `Sirupsen/logrus` to `sirupsen/logrus` Signed-off-by: Suraj Narwade <[email protected]> Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
fix-logrus
branch
from
4a4bf14 to
6cfd21b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed namechange in
Sirupsen/logrustosirupsen/logrus