Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Conversation

@CpuID
Copy link
Contributor

@CpuID CpuID commented Aug 21, 2018

Second attempt at #497 - at a bare minimum to be able to accept files with 2.1, 2.2, etc for now, and stub out where we would put 3.x support later.

This is by no means a comprehensive implementation, but would most likely fix:

#490
#486
#474
#441

And at least error elegantly for #421 for now.

@CpuID
Copy link
Contributor Author

CpuID commented Aug 21, 2018

Note: the credit for most of this goes to @cheapRoc

@CpuID
Copy link
Contributor Author

CpuID commented Aug 21, 2018

This really could use test coverage around some 2.x and 3.x version numbers, I don't have the cycles to touch it today. I'll see how things go soonish.

Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a near future I think there would be better way to do that (à-la docker/cli), but if it unblocks people, let's get that in.

LGTM 🐯

@vdemeester vdemeester merged commit a86fb3c into docker-archive-public:master Aug 21, 2018
@CpuID CpuID deleted the cpuid_pr497_take2 branch August 21, 2018 10:11
@CpuID
Copy link
Contributor Author

CpuID commented Aug 21, 2018

awesome, thx for merging so fast :)

@jwreagor
Copy link

Thanks @CpuID. Shame my project fell through but glad I could help here in some way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants