Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Conversation

@CpuID
Copy link
Contributor

@CpuID CpuID commented Sep 14, 2018

Adds support under the build heading for:

  • cache_from
  • labels
  • network
  • target

Note: network is undocumented in the docker-compose.yml reference but is supported and works (as of config version 3.4).

@vdemeester do we also need these in docker/service/service.go?

@CpuID
Copy link
Contributor Author

CpuID commented Sep 14, 2018

Now that's interesting, the acceptance tests fail yet Jenkins passes?

Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎐

@vdemeester
Copy link
Contributor

@CpuID yes, the acceptance tests is merely there to see how close (or not) we are to support the full range of docker-compose feature, that's why it's not taken into account in the final result of the build… Otherwise, no tests would pass… 😅

@vdemeester vdemeester merged commit 1535bda into docker-archive-public:master Sep 14, 2018
@CpuID
Copy link
Contributor Author

CpuID commented Sep 14, 2018

np thx, calling "mission accomplished" in that case :)

@CpuID CpuID deleted the cpuid_build_options branch September 14, 2018 09:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants