Cleanup/reformatting/php8 warnings/notices, some improvements #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace deprecated utf8 functions
isDiscusssionEnabled is used in update_comment_status(), which is triggered by the use of the meta renderer. In pageinfo() the $INFO array is collected, which requires the meta renderer. So we cannot use yet $INFO here.
This was referenced Sep 21, 2022
Closed
If as last action a comment was removed, the .comment file is recenter then the latest comment. Ignores modified comments. Fixes #226
This was referenced Sep 25, 2022
Closed
status update event has two function: 1. store metadata status if different from the current config status 2. update the existing status with the configsetting(or if existing from the metadata, which overrides the configsetting)
This was referenced Sep 25, 2022
Closed
mprins
approved these changes
Nov 16, 2022
Contributor
mprins
left a comment
mprins
left a comment
There was a problem hiding this comment.
should fix warnings
PHP message: PHP Warning: Undefined array key "comment" in /dokuwiki/lib/plugins/discussion/action.php on line 222
PHP message: PHP Warning: Undefined array key "number" in /dokuwiki/lib/plugins/discussion/action.php on line 1434
mprins
reviewed
Nov 16, 2022
Member
Author
You meant that this is already solved by this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.