Remove check for hasChildren
#537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current iteration has the flag for "hasChildren" set to true, even though it has no children. But, because that flag was set, it was filtered out of the possible values for an iteration. This fix does mean some very old values are included in the list of "all iterations". Those don't match any of the current patterns, so I chose the smallest code change possible. This logic could be modified to remove iterations from old patterns, but that seems unnecessary at this time.
IEvangelist
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current iteration has the flag for "hasChildren" set to true, even though it has no children.
But, because that flag was set, it was filtered out of the possible values for an iteration.
This fix does mean some very old values are included in the list of "all iterations". Those don't match any of the current patterns, so I chose the smallest code change possible. This logic could be modified to remove iterations from old patterns, but that seems unnecessary at this time.