Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Conversation

@Bunn
Copy link
Contributor

@Bunn Bunn commented Jan 15, 2025

Task/Issue URL: https://app.asana.com/0/1204167627774280/1209160773739107/f

Description:
Add a debug settings in the debug UI for people to be able to allow a custom domain in the message policy

Steps to test this PR:

  1. Add a breakpoint here
  2. Open a new tab, make sure the breakpoint is not called
  3. Go to the debug UI, AI Chat, then set a custom hostname
  4. Open a new tab, make sure the breakpoint is called with the data you set before
  5. Go to the debug UI, AI Chat, then reset the custom domain
  6. Open a new tab, make sure the breakpoint is not called

@Bunn Bunn requested a review from brindy January 15, 2025 15:30
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I checked that rules.append(.exact(hostname: debugHostname)) was only called when a host name had been set.

Couple of SwiftLint things to fix, but approved.

@Bunn Bunn merged commit c8fef6e into main Jan 15, 2025
13 checks passed
@Bunn Bunn deleted the bunn/aichat/debug branch January 15, 2025 16:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants