Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Conversation

@Bunn
Copy link
Contributor

@Bunn Bunn commented Jan 15, 2025

Task/Issue URL: https://app.asana.com/0/1204167627774280/1209157710205507/f

Description:
Remove AIChatWebViewController from memory once the view is dismissed

Steps to test this PR:

  1. Make sure to set internal user state
  2. Smoke test opening AI Chat. Open it from the address bar if you're in the SERP, open it from the browser menu
  3. Inspect memory or add a log like
    deinit {
        print("BYE")
    }

in AIChatWebViewController and make sure that every time you dismiss it, the view is called.

@Bunn Bunn requested a review from brindy January 15, 2025 17:05
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bunn Bunn merged commit b42ccfa into main Jan 16, 2025
16 checks passed
@Bunn Bunn deleted the bunn/aichat/remove-prewarm branch January 16, 2025 12:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants