Allow heartbeating a request #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| local count = 0 | ||
| local bulk = redis.call('HGETALL', rate_limit_key) | ||
| local nextkey | ||
| for i, v in ipairs(bulk) do |
There was a problem hiding this comment.
This is O(N) on the number of requests for a key - is that OK?
There was a problem hiding this comment.
It's not what I'd love to do but the N is going to be small and it's the same implementation as the way we calculate concurrency for take
redis_rate/script_concurrency_take.lua
Lines 22 to 32 in 94b3aa6
phoebesimon
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.