Skip to content

[23683] Fix default fixed-string length bug (backport #275) #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2025
Merged

[23683] Fix default fixed-string length bug (backport #275) #276

merged 1 commit into from
Sep 10, 2025

Conversation

@mergify
Copy link

@mergify mergify bot commented Sep 10, 2025

Description

This PR fixes wrong behavior with fixed strings which had a default value longer than the serialized one.

@Mergifyio backport 2.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.
This is an automatic backport of pull request #275 done by [Mergify](https://mergify.com).

@mergify mergify bot mentioned this pull request Sep 10, 2025
Merged
11 tasks
@MiguelCompany MiguelCompany self-requested a review September 10, 2025 07:24
@MiguelCompany MiguelCompany added this to the v2.2.7 milestone Sep 10, 2025
@MiguelCompany
Copy link
Member

MiguelCompany commented Sep 10, 2025

@Mergifyio rebase

@jepemi @MiguelCompany
Fix default fixed-string length bug (#275)
9a963cd 
* Refs #23683: Add regression unit test

Signed-off-by: Jesus Perez <[email protected]>

* Refs #23683: Add regression top test

Signed-off-by: Jesus Perez <[email protected]>

* Refs #23683: Fix implementation

Signed-off-by: Jesus Perez <[email protected]>

---------

Signed-off-by: Jesus Perez <[email protected]>
(cherry picked from commit 60c176d)
@mergify
Copy link
Author

mergify bot commented Sep 10, 2025

rebase

✅ Branch has been successfully rebased

@MiguelCompany MiguelCompany force-pushed the mergify/bp/2.2.x/pr-275 branch from 8550d32 to 9a963cd Compare September 10, 2025 08:17
@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany September 10, 2025 08:17
@MiguelCompany MiguelCompany merged commit 42db576 into 2.2.x Sep 10, 2025
11 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/2.2.x/pr-275 branch September 10, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

No one assigned

Labels

ci-pending

Projects

None yet

Milestone

v2.2.7

Development

Successfully merging this pull request may close these issues.

3 participants

@MiguelCompany @jepemi