Skip to content

Conversation

@richiware
Copy link
Member

@richiware richiware commented Oct 30, 2025

Description

CMake 3.25 introduces CMAKE_MSVC_DEBUG_INFORMATION_FORMAT to change "/Zi" MSVC option. For this reason this PR remove the manually mechanism to change it. Now a user can this CMAKE options to have the same behaviour:

-DCMAKE_POLICY_DEFAULT_CMP0141=NEW  -DCMAKE_MSVC_DEBUG_INFORMATION_FORMAT="$<$<CONFIG:Debug>:Embedded>"

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.

Signed-off-by: Ricardo González <[email protected]>
@MiguelCompany MiguelCompany added this to the v2.3.4 milestone Oct 30, 2025
@richiware richiware merged commit c88e2ea into master Oct 30, 2025
12 checks passed
@richiware richiware deleted the feature/msvc-debug-format branch October 30, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants