Skip to content

[23858] Build with warnings as errors (backport #289) #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2025
Merged

[23858] Build with warnings as errors (backport #289) #290

merged 1 commit into from
Oct 31, 2025

Conversation

@mergify
Copy link

@mergify mergify bot commented Oct 31, 2025

Description

Just what the title says. We want builds to fail if there are warnings.

@Mergifyio backport 2.2.x 1.0.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.
This is an automatic backport of pull request #289 done by [Mergify](https://mergify.com).

@MiguelCompany @richiware @mergify
Build with warnings as errors (#289)
4ad5c78 
* Refs #23858. Build with warnings as errors.

Signed-off-by: Miguel Company <[email protected]>

* Refs #23858. Add option for MSVC

Signed-off-by: Miguel Company <[email protected]>

* Refs #23858. Fix warning.

Signed-off-by: Miguel Company <[email protected]>

* Refs #23858. Move to CI

Signed-off-by: Ricardo González Moreno <[email protected]>

* Apply suggestion

Co-authored-by: Miguel Company <[email protected]>
Signed-off-by: Ricardo González <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González <[email protected]>
Co-authored-by: Ricardo González Moreno <[email protected]>
(cherry picked from commit 9beec7e)
@mergify mergify bot mentioned this pull request Oct 31, 2025
Merged
10 tasks
@MiguelCompany MiguelCompany added this to the v2.2.7 milestone Oct 31, 2025
@MiguelCompany MiguelCompany self-requested a review October 31, 2025 09:25
@MiguelCompany MiguelCompany merged commit a02c569 into 2.2.x Oct 31, 2025
12 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/2.2.x/pr-289 branch October 31, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

No one assigned

Labels

ci-pending

Projects

None yet

Milestone

v2.2.7

Development

Successfully merging this pull request may close these issues.

2 participants

@MiguelCompany