-
-
Notifications
You must be signed in to change notification settings - Fork 102
update Vanhove reference on multicollinearity #865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @bbolker, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating a key reference within the codebase and its associated documentation. Specifically, it replaces a citation to a web page by J. Vanhove regarding multicollinearity with its corresponding published article in an open-access journal. This ensures that the project's references are current and point to the most formal and peer-reviewed version of the work. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates a reference for Vanhove on multicollinearity, changing it from a webpage to a published journal article. While the updated reference is valuable, there's a minor formatting issue in the Roxygen documentation comment. I've provided a specific suggestion to correct the formatting, which will ensure the reference is displayed correctly as a list item in the package documentation.
man/check_collinearity.Rd
Outdated
\item Vanhove, J. (2019). Collinearity isn't a disease that needs curing. | ||
\href{https://janhove.github.io/posts/2019-09-11-collinearity/}{webpage} | ||
|
||
Vanhove, J. (2021) Collinearity Isn’t a Disease That Needs Curing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Is |
in theory URL should be OK, but DOI is better in any case ... |
Thanks! |
Vanhove web page on multicollinearity has now been published in an open access journal (being published rather than "just a web page" might help people accept its arguments better)