Skip to content

Conversation

bbolker
Copy link
Contributor

@bbolker bbolker commented Oct 14, 2025

Vanhove web page on multicollinearity has now been published in an open access journal (being published rather than "just a web page" might help people accept its arguments better)

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @bbolker, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating a key reference within the codebase and its associated documentation. Specifically, it replaces a citation to a web page by J. Vanhove regarding multicollinearity with its corresponding published article in an open-access journal. This ensures that the project's references are current and point to the most formal and peer-reviewed version of the work.

Highlights

  • Reference Update: The citation for J. Vanhove's work on multicollinearity has been updated from a web page to its newly published open-access journal article.
  • Credibility Enhancement: The change reflects a more authoritative source, potentially increasing the perceived credibility of the referenced arguments.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates a reference for Vanhove on multicollinearity, changing it from a webpage to a published journal article. While the updated reference is valuable, there's a minor formatting issue in the Roxygen documentation comment. I've provided a specific suggestion to correct the formatting, which will ensure the reference is displayed correctly as a list item in the package documentation.

\item Vanhove, J. (2019). Collinearity isn't a disease that needs curing.
\href{https://janhove.github.io/posts/2019-09-11-collinearity/}{webpage}

Vanhove, J. (2021) Collinearity Isnt a Disease That Needs Curing.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This reference is missing the \item tag, which will cause it to be improperly formatted in the package documentation. This is likely a result of the formatting issue in the R/check_collinearity.R file. Fixing the roxygen2 comment there and regenerating this .Rd file should resolve this issue.

@strengejacke
Copy link
Member

Thanks! Is url{} ok or do CRAN checks require using \doi{}?

@bbolker
Copy link
Contributor Author

bbolker commented Oct 14, 2025

in theory URL should be OK, but DOI is better in any case ...

@strengejacke
Copy link
Member

Thanks!

@strengejacke strengejacke merged commit 99c1222 into easystats:main Oct 14, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants