Fixes for ProxyRequest and ProxyResponse with null Body #111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #110
In some cases, users want to skip the proxied request or the backend response entirely. To do so, they can set a null
Body
inProxyRequest
orProxyResponse
.However:
ProxyRequest
, it led to a NPEProxyResponse
, the content length was not overwritten if presentAlso, in the test, we should make sure that the futures returned by
context.sendRequest
andcontext.sendResponse()
are completed.The completion signal is important because it helps users trigger cleanup actions (e.g. delete temp files)