Introduce OriginRequestProvider #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes eclipse-vertx#35, closes eclipse-vertx#44 OriginRequestProvider is a Vert.x API type that unifies all the origin selection methods currently present as overloaded methods in HttpProxy. OriginRequestProvider being a FunctionalInterface, users can provide one in the form of a lambda. OriginRequestProvider is a little different from the existing contract. Instead of the proxied request and HTTP client as parameters, it has the ProxyContext (that exposes all the proxy data and the client). This allows implementations to make a decision on the modifications interceptors can make (including when the request is an upgrade to WebSocket). See eclipse-vertx#44 It also allows interceptor and provider to exchange data via the ProxyContext attachments. See eclipse-vertx#35 Signed-off-by: Thomas Segismont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #121