Skip to content

Conversation

@colligant
Copy link

This PR changes the general "Exception" in api.py to ValueError.
From the python docs:

ValueError:
Raised when an operation or function receives an argument that has the right type but an inappropriate value, and the situation is not described by a more precise exception such as IndexError 

In general using "Exception" is a bit ambiguous and not recommended for production.

@FussyDuck
Copy link

FussyDuck commented Oct 22, 2024

CLA assistant check
All committers have signed the CLA.

@veenstrajelmer
Copy link

@EddyCMWF could you please review and merge this? this is a useful improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants