feat: support not to auto check update & manual check update

[rhy3h]

Implemented the issue #164

• autoCheck - which defaults to true. It can be set to false to disable automatic update checks.
• checkForUpdates() - manually check for updates.

However, I did not implement the final installUpdate function
Because the correct installation process should be executed after the file has been downloaded

autoUpdater.once('update-downloaded', () => {
  autoUpdater.quitAndInstall();
});

[rhy3h]

Friendly ping! Any feedback on this?

[erickzhao]

@rhy3h Hey! Haven't gotten around to reviewing it yet, thanks for the ping. Hopefully can get that done for you in the next week or two?

[rhy3h]

@erickzhao Hey! No worries at all, I really appreciate you taking the time. I just started contributing to PRs recently, so I’d love to know if I’m doing things correctly. No rush at all!

[rhy3h]

Just checking in again—no rush at all, and really appreciate your time. Would love any feedback whenever you get a chance!

[dariuszjastrzebski]

@erickzhao have you had chance to check this PR? This changes gain greater control over when and how updates are managed in the application. I would be grateful for your feedback

[rhy3h]

FYI
I just find out linux do not support auto update
so I skip the test when in linux platform

[erickzhao]

Suggested change

	/**
	* @param {Boolean} autoCheck Decides whether to automatically check for updates
	* Defaults to `true`.
	*/
	/**
	* @param {Boolean} autoCheck Decides whether to automatically check for updates
	* @default true
	*/

[rhy3h]

In other comments

update-electron-app/src/index.ts

Lines 98 to 107 in c5f1d43

	/**
	* @param {Object} logger A custom logger object that defines a `log` function.
	* Defaults to `console`. See electron-log, a module
	* that aggregates logs from main and renderer processes into a single file.
	*/
	readonly logger?: L;
	/**
	* @param {Boolean} notifyUser Defaults to `true`. When enabled the user will be
	* prompted to apply the update immediately after download.
	*/

those writing style uses indentation
so I do that too
which one should I follow

[erickzhao]

Suggested change

	if (autoCheck) {
	if (autoCheck === true) {

I wonder if we want to be stricter about actually passing true rather than something truthy.

[rhy3h]

update-electron-app/src/index.ts

Line 216 in c5f1d43

if (opts.notifyUser) {

I follow this, so I didn't do strict equal
I agree with you, it might need stricter

[erickzhao]

We should add a JSDoc comment for the new manual checkForUpdates function as well.

[rhy3h]

rhy3h@7019793
please see this commit

[MarshallOfSound]

Blocking comment on IMO bad api surface