Refactor how we deal with user permissions. #4235
Conversation
…ions. This patch introduces a new RoomPowerLevelsProxy and its associated mock and adopts newer Rust APIs to make working with user power levels and permissions easier.
Generated by 🚫 Danger Swift against c053e93 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4235 +/- ##
========================================
Coverage 79.17% 79.17%
========================================
Files 798 798
Lines 74915 74927 +12
========================================
+ Hits 59311 59325 +14
+ Misses 15604 15602 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ElementX/Sources/Screens/KnockRequestsListScreen/KnockRequestsListScreenViewModel.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
So silly question. Can we now include this powerLevels struct in Rust's roomInfo so that we don't even need to await a get on it?
There was a problem hiding this comment.
That way we could just use the RoomInfoProxy from the publisher in all these screens like we do for everything else.
There was a problem hiding this comment.
Oh yeah, that's a really good idea. Let me see if I can push it through Rust side
stefanceriu
force-pushed
the
stefan/powerLevels
branch
from
09cf0af to
c053e93
Compare
|
This patch introduces a new RoomPowerLevelsProxy and its associated mock and adopts newer Rust APIs to make working with user power levels and permissions easier.