Skip to content

ProcessInfoView: cleanup and code style #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2025
Merged

ProcessInfoView: cleanup and code style #485

merged 1 commit into from
Oct 8, 2025
+35 −45

Conversation

danirabbit
Copy link
Member

  • Use construct and instantiate everything there
  • Remove unused public string? icon_name
  • Replace Grid with Box
  • Reduce scope of buttons
  • Get application name from Process, not another part of the UI
  • Fix bracket indentation
  • minor code style stuff

@danirabbit danirabbit requested a review from a team October 8, 2025 18:24
stsdc
stsdc approved these changes Oct 8, 2025
View reviewed changes
Copy link
Member

@stsdc stsdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@stsdc stsdc merged commit de1812c into main Oct 8, 2025
4 checks passed
@stsdc stsdc deleted the danirabbit/processinfoview-cleanup branch October 8, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stsdc stsdc stsdc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danirabbit @stsdc