Skip to content

include ember-data custom transforms in namespace #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 3, 2016

Conversation

koriroys
Copy link
Contributor

@koriroys koriroys commented Mar 3, 2016

allow models to have custom DS.attr transforms

allow models to have custom DS.attr transforms
@tricknotes
Copy link
Member

Thanks @koriroys
It seems good 👍

Could you update test against this behavior?
https://github.com/emberjs/ember-rails/blob/master/test/es6_modeul_test.rb#L5

koriroys added 2 commits March 3, 2016 11:39
allows any custom DS transforms to be auto-included
@tricknotes
Copy link
Member

There is a falling test here.

Error: test_transforms_type_module_should_be_registered_with_module_prefix(Es6ModuleTest): > ActionController::RoutingError: No route matches [GET] "/assets/transforms/user.js"

To fix this test, could you add the following file?
test/dummy/app/assets/javascripts/transforms/user.module.es6

import DS from 'ember-data';

export default DS.Transform.extend({

});

@koriroys
Copy link
Contributor Author

koriroys commented Mar 3, 2016

Yeah sorry. I just did it real quick on github, thought it would be less involved. 😸 good thing your tests catch it though.

@tricknotes
Copy link
Member

All tests are passed 💚
Thanks for your nice fix @koriroys 🚀

tricknotes added a commit that referenced this pull request Mar 3, 2016
include ember-data custom transforms in namespace
@tricknotes tricknotes merged commit f83cd19 into emberjs:master Mar 3, 2016
@koriroys
Copy link
Contributor Author

koriroys commented Mar 4, 2016

No problemo. Thanks for the sweet gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants