Remove type mismatched default value from generator options #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has some failing tests due to API change from dependent gems. |
Since [email protected], the warning message is shown for default type mismatch. ref: rails/thor@605897b We expect these options to be `nil` by default.
tricknotes
force-pushed
the
fix-default-option
branch
from
dafd110 to
e4c0500
Compare
oblakeerickson
added a commit
to discourse/discourse
that referenced
this pull request
Sep 4, 2020
We are switching over to a fork because we are currently on a pinned version of ember-rails 0.18.5 which is pretty old. Upgrading to the latest version causes many things to break which isn't really worth the time to debug while we plan to completely switch over to ember-cli somewhat soonish. Our fork contains a single cherry-pick commit emberjs/ember-rails#534 which will fix an issue when running the `rails g migration` command and it spits out a bunch of deprecation warnings.
oblakeerickson
added a commit
to discourse/discourse
that referenced
this pull request
Sep 4, 2020
We are switching over to a fork because we are currently on a pinned version of ember-rails 0.18.5 which is pretty old. Upgrading to the latest version causes many things to break which isn't really worth the time to debug while we plan to completely switch over to ember-cli somewhat soonish. Our fork contains a single cherry-pick commit emberjs/ember-rails#534 which will fix an issue when running the `rails g migration` command and it spits out a bunch of deprecation warnings.
oblakeerickson
added a commit
to discourse/discourse
that referenced
this pull request
Sep 8, 2020
We are switching over to a fork because we are currently on a pinned version of ember-rails 0.18.5 which is pretty old. Upgrading to the latest version causes many things to break which isn't really worth the time to debug while we plan to completely switch over to ember-cli somewhat soonish. Our fork contains a single cherry-pick commit emberjs/ember-rails#534 which will fix an issue when running the `rails g migration` command and it spits out a bunch of deprecation warnings.
pmusaraj
pushed a commit
to discourse/discourse
that referenced
this pull request
Sep 10, 2020
We are switching over to a fork because we are currently on a pinned version of ember-rails 0.18.5 which is pretty old. Upgrading to the latest version causes many things to break which isn't really worth the time to debug while we plan to completely switch over to ember-cli somewhat soonish. Our fork contains a single cherry-pick commit emberjs/ember-rails#534 which will fix an issue when running the `rails g migration` command and it spits out a bunch of deprecation warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since [email protected], the warning message is shown for default type
mismatch.
ref: rails/thor@605897b
We expect these options to be
nilby default.