Update Ruby versions on Travis CI #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htwroclau
force-pushed
the
update_ruby_versions
branch
from
f4b22ff to
3a3adad
Compare
tricknotes
approved these changes
Apr 22, 2018
There was a problem hiding this comment.
@htwroclau
Thanks for your contribution and sorry for my late :<
This PR seems great 💚
NOTE: I left some comments. If you are interested in it, please teach me what happened in webmock :-)
| @@ -19,7 +19,7 @@ def copy_directory(dir) | |||
| def set_test_environment | |||
| VCR.configure do |c| | |||
| c.cassette_library_dir = 'test/fixtures/vcr_cassettes' | |||
| c.hook_into :webmock # or :fakeweb | |||
| c.hook_into :faraday # or :webmock or :fakeweb | |||
There was a problem hiding this comment.
Hmm, perhaps it seems a webmock issue on jRuby.
However I'm not sure why the following tests are failed.
https://travis-ci.org/emberjs/ember-rails/jobs/363684591
| @@ -24,6 +24,7 @@ Gem::Specification.new do |s| | |||
| s.add_dependency "ember-cli-assets", "~> 0.0.1" | |||
|
|
|||
| s.add_development_dependency "bundler", [">= 1.2.2"] | |||
| s.add_development_dependency "faraday" | |||
There was a problem hiding this comment.
I prefer not adding a new dependency.
But it makes sense to pass ember-rails tests.
| @@ -28,7 +28,7 @@ class HjsTemplateTest < IntegrationTest | |||
| get "/assets/templates/hairy.js" | |||
| assert_response :success | |||
| assert_match %r{Ember\.TEMPLATES\["hairy(\.mustache)?"\] = Ember\.(?:Handlebars|HTMLBars)\.template\(}m, @response.body | |||
| assert_match %r{function .*unbound|"name":"unbound"|\[\\"unbound\\"\]}m, @response.body | |||
| assert_match %r{.*unbound|"name":"unbound"|\[\\"unbound\\"\]}m, @response.body | |||
There was a problem hiding this comment.
I see.
Some update in ember-source may change the templates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I try to update Ruby versions on Travis CI.
However, as test errors occurred, I also addressed the following.