dropped AWS signature #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
according to https://developer-docs.amazon.com/sp-api/changelog/sp-api-will-no-longer-require-aws-iam-or-aws-signature-version-4 this is no longer required
ericcj
reviewed
Feb 28, 2024
| module AmzSpApi | ||
| class SpConfiguration < Configuration | ||
| attr_accessor :refresh_token, :client_id, :client_secret, :sandbox, :region, | ||
| :aws_access_key_id, :aws_secret_access_key, :credentials_provider, # either access key or credentials_provider for AWS Signer, e.g. Aws::STS::Client |
There was a problem hiding this comment.
these incompatible API changes would force this to be part of a major version change whereas if we left them in place and even better added this we could roll it out in a patch
extend Gem::Deprecate
deprecate :aws_access_key_id=, :none, 2025, 1
deprecate :aws_secret_access_key=, :none, 2025, 1
deprecate :credentials_provider=, :none, 2025, 1
|
@ericcj we've been using it like this since I opened the PR :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to https://developer-docs.amazon.com/sp-api/changelog/sp-api-will-no-longer-require-aws-iam-or-aws-signature-version-4 this is no longer required