Skip to content

msgtwscr: Temporarily activate scroll on twist function when a new message triggers the message app. #3866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 24, 2025

Conversation

thyttan
Copy link
Collaborator

@thyttan thyttan commented May 26, 2025

Can be installed from my app loader: https://thyttan.github.io/BangleApps/?id=msgtwscr

previous now closed PR: #3714

@thyttan
Copy link
Collaborator Author

thyttan commented Jun 19, 2025

I think this works well enough. Logic could be made more sophisticated in the future.

@thyttan thyttan marked this pull request as ready for review June 19, 2025 07:22
@gfwilliams
Copy link
Member

Sorry - just noticed one more thing. It's probably best to change function onTwistEmitDrag to let onTwistEmitDrag = function... because otherwise the function will end up being global - while {} hide let/const it doesn't work for var or function

@thyttan
Copy link
Collaborator Author

thyttan commented Jun 24, 2025

I wonder why I didn't do that in the first place 🤔👍

@thyttan
Copy link
Collaborator Author

thyttan commented Jun 24, 2025

Fixed 👌

@gfwilliams
Copy link
Member

Thanks!

@gfwilliams gfwilliams merged commit cfb58bc into espruino:master Jun 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants