WIP: 0.3.0 developments #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Generated by 🚫 Danger |
tuxmea
reviewed
Sep 4, 2017
site/profile/manifests/monitor.pp
Outdated
| # profile::monitor::hostname as default) | ||
| # @params ip Entry point for the IP to use as default by different | ||
| # monitoring profiles | ||
| # @params ip Entry point for the interface to use as default by different |
Contributor
There was a problem hiding this comment.
parameter has name interface, not ip
tuxmea
reviewed
Sep 4, 2017
| # | ||
| class profile::monitor ( | ||
| Boolean $manage = $::profile::settings::monitor_manage, | ||
| Boolean $enable = $::profile::settings::monitor_enable, |
Contributor
There was a problem hiding this comment.
Parameter enable is not documented.
use correct puppetserver gem command to install gems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.