Skip to content

animationManager: stop playing animation when there is none available #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2025

Conversation

Lgt2x
Copy link
Member

@Lgt2x Lgt2x commented Jul 5, 2025

When opening a non-temporal dataset and pressing space to run the animation, the console would get spammed with messages "No animation available, cannot load a specific animation time" on every tick. We now show a single warning and stop the animation after the first failure.

I did not bother adding a full interaction+regexp test for such a small fix, but let me know if you think it would be valuable anyway.

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated timestamp

Continuous integration

Please check the checkbox of the CI you want to run, then push again on your branch.

  • Style checks
  • Fast CI
  • Coverage cached CI
  • Analysis cached CI
  • WASM docker CI
  • Android docker CI
  • macOS Intel cached CI
  • macOS ARM cached CI
  • Windows cached CI
  • Linux cached CI
  • Other cached CI

@mwestphal
Copy link
Member

no need for a test, but can you target release ? I think we want this in 3.2.

I'll take care of backporting to master later, its all part of the process.

@Lgt2x Lgt2x changed the base branch from master to release July 5, 2025 19:25
@mwestphal
Copy link
Member

nice, lets enable all CI and push an empty commit to trigger it, thanks

When opening a non-temporal dataset and pressing space to run the animation, the console would get spammed with messages "No animation available, cannot load a specific animation time" on every tick. We now show a single warning and stop the animation after the first failure.
@Lgt2x Lgt2x force-pushed the stop-animation branch from 2b900cc to cef7871 Compare July 5, 2025 19:50
Copy link

codecov bot commented Jul 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.18%. Comparing base (8d04b92) to head (cef7871).
Report is 339 commits behind head on release.

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #2365      +/-   ##
===========================================
+ Coverage    95.67%   96.18%   +0.50%     
===========================================
  Files          125      134       +9     
  Lines         9947    12108    +2161     
===========================================
+ Hits          9517    11646    +2129     
- Misses         430      462      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwestphal mwestphal merged commit 4bf67c6 into f3d-app:release Jul 6, 2025
83 checks passed
@mwestphal
Copy link
Member

Thanks for the contribution @Lgt2x !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants