animationManager: stop playing animation when there is none available #2365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a non-temporal dataset and pressing space to run the animation, the console would get spammed with messages "No animation available, cannot load a specific animation time" on every tick. We now show a single warning and stop the animation after the first failure.
I did not bother adding a full interaction+regexp test for such a small fix, but let me know if you think it would be valuable anyway.
Checklist for finalizing the PR
.github/workflows/versions.json
, I have updatedtimestamp
Continuous integration
Please check the checkbox of the CI you want to run, then push again on your branch.