Skip to content

merge release into master #2372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 7, 2025
Merged

merge release into master #2372

merged 5 commits into from
Jul 7, 2025

Conversation

mwestphal
Copy link
Member

Describe your changes

Issue ticket number and link if any

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated timestamp

Continuous integration

Please check the checkbox of the CI you want to run, then push again on your branch.

  • Style checks
  • Fast CI
  • Coverage cached CI
  • Analysis cached CI
  • WASM docker CI
  • Android docker CI
  • macOS Intel cached CI
  • macOS ARM cached CI
  • Windows cached CI
  • Linux cached CI
  • Other cached CI

mwestphal and others added 5 commits July 5, 2025 21:00
merge master into release
…#2365)

When opening a non-temporal dataset and pressing space to run the animation, the console would get spammed with messages "No animation available, cannot load a specific animation time" on every tick. We now show a single warning and stop the animation after the first failure.
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

Attention: Patch coverage is 98.72242% with 11 lines in your changes missing coverage. Please review.

Project coverage is 96.21%. Comparing base (d2a953f) to head (b55ce8e).
Report is 140 commits behind head on master.

Files with missing lines Patch % Lines
application/F3DStarter.cxx 95.72% 5 Missing ⚠️
library/src/animationManager.cxx 97.91% 2 Missing ⚠️
library/src/interactor_impl.cxx 96.07% 2 Missing ⚠️
library/src/log.cxx 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2372      +/-   ##
==========================================
+ Coverage   95.86%   96.21%   +0.34%     
==========================================
  Files         127      134       +7     
  Lines       11061    12113    +1052     
==========================================
+ Hits        10604    11654    +1050     
- Misses        457      459       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwestphal mwestphal requested a review from Meakk July 7, 2025 06:50
@mwestphal mwestphal merged commit 041870f into master Jul 7, 2025
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants