Skip to content

Add pdal feature Attempt 1 #2380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

RealEdwardS
Copy link

@RealEdwardS RealEdwardS commented Jul 9, 2025

Describe your changes

Issue ticket number and link if any

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated timestamp

Continuous integration

Please check the checkbox of the CI you want to run, then push again on your branch.

  • Style checks
  • Fast CI
  • Coverage cached CI
  • Analysis cached CI
  • WASM docker CI
  • Android docker CI
  • macOS Intel cached CI
  • macOS ARM cached CI
  • Windows cached CI
  • Linux cached CI
  • Other cached CI

@mwestphal
Copy link
Member

Hi @RealEdwardS

Looks like this is ongoing, do not hesitate to ping me here or on discord when you need a review :)

@RealEdwardS
Copy link
Author

Fixed and added some material.

Right now I've skipped some supported PDAL types including faux, i3s, memoryview, pgpointcloud, and tindex, since they're not files, but other buffers/mediums?

The gdal has a lot of files it supports, I still need to add all of them if necessary.

Hopefully I'm on the right path, if I am, I'll continue and add some testing.

Thanks :)

@mwestphal
Copy link
Member

The gdal has a lot of files it supports, I still need to add all of them if necessary.

Lets only add the one that we test and that makes sense. We dont need to add every single format.

@mwestphal
Copy link
Member

Hopefully I'm on the right path, if I am, I'll continue and add some testing.

Let me know when you need a review or want to discuss how to do things :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants