Skip to content

App: Rework handling of invalid file for better watch support #2392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 14, 2025

Conversation

mwestphal
Copy link
Member

@mwestphal mwestphal commented Jul 11, 2025

Describe your changes

Issue ticket number and link if any

Fix #2246
Fix #2354

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated timestamp

Continuous integration

Please check the checkbox of the CI you want to run, then push again on your branch.

  • Style checks
  • Fast CI
  • Coverage cached CI
  • Analysis cached CI
  • WASM docker CI
  • Android docker CI
  • macOS Intel cached CI
  • macOS ARM cached CI
  • Windows cached CI
  • Linux cached CI
  • Other cached CI

@mwestphal mwestphal marked this pull request as ready for review July 11, 2025 06:18
@mwestphal mwestphal force-pushed the watch_invalid_rework branch from f2c7828 to 3f5fc23 Compare July 11, 2025 21:31
@mwestphal mwestphal force-pushed the watch_invalid_rework branch from d7977d9 to dafb3df Compare July 12, 2025 06:09
Copy link

codecov bot commented Jul 12, 2025

Codecov Report

Attention: Patch coverage is 95.65217% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.18%. Comparing base (2c9afe5) to head (f1b18c5).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
application/F3DStarter.cxx 95.65% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2392   +/-   ##
=======================================
  Coverage   96.18%   96.18%           
=======================================
  Files         134      134           
  Lines       12114    12118    +4     
=======================================
+ Hits        11652    11656    +4     
  Misses        462      462           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mwestphal mwestphal requested review from Meakk and snoyer July 12, 2025 15:06
mwestphal and others added 3 commits July 13, 2025 22:16
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mwestphal mwestphal requested a review from Meakk July 14, 2025 09:30
@mwestphal mwestphal merged commit 5f14871 into f3d-app:master Jul 14, 2025
157 of 159 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-watch flag can crash f3d.exe supported files stop being --watched if they fail to load
3 participants