-
-
Notifications
You must be signed in to change notification settings - Fork 315
CI: Add missing deps to the CI cache version system #2393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You are modifying versions.json, please update the timestamp as well, this will generate new docker images and caches needed for CI. |
d78bd23
to
67dae26
Compare
67dae26
to
51976ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- .github/workflows/ci.yml
- lines 395-395
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2393 +/- ##
=======================================
Coverage 96.18% 96.18%
=======================================
Files 134 134
Lines 12114 12114
=======================================
Hits 11652 11652
Misses 462 462 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- .github/workflows/ci.yml
- lines 923-923
Describe your changes
Issue ticket number and link if any
Related to #194
Checklist for finalizing the PR
.github/workflows/versions.json
, I have updatedtimestamp
Continuous integration
Please check the checkbox of the CI you want to run, then push again on your branch.