Skip to content

CI: Add missing deps to the CI cache version system #2393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jul 12, 2025

Conversation

mwestphal
Copy link
Member

@mwestphal mwestphal commented Jul 11, 2025

Describe your changes

  • Add imath, blosc, zlib, tbb to the CI cache version system
  • Exprim that openexr depends on imath
  • Use min versions for imath, blosc zlib and tbb in the mindep build

Issue ticket number and link if any

Related to #194

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated timestamp

Continuous integration

Please check the checkbox of the CI you want to run, then push again on your branch.

  • Style checks
  • Fast CI
  • Coverage cached CI
  • Analysis cached CI
  • WASM docker CI
  • Android docker CI
  • macOS Intel cached CI
  • macOS ARM cached CI
  • Windows cached CI
  • Linux cached CI
  • Other cached CI

Copy link

github-actions bot commented Jul 11, 2025

You are modifying versions.json, please update the timestamp as well, this will generate new docker images and caches needed for CI.

@mwestphal mwestphal marked this pull request as ready for review July 11, 2025 06:18
@mwestphal mwestphal changed the title CI: Add imath to the CI cache version system CI: Add missing deps to the CI cache version system Jul 12, 2025
@mwestphal mwestphal requested a review from Meakk July 12, 2025 11:58
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • .github/workflows/ci.yml
    • lines 395-395

Copy link

codecov bot commented Jul 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.18%. Comparing base (2c9afe5) to head (ad9f21a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2393   +/-   ##
=======================================
  Coverage   96.18%   96.18%           
=======================================
  Files         134      134           
  Lines       12114    12114           
=======================================
  Hits        11652    11652           
  Misses        462      462           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • .github/workflows/ci.yml
    • lines 923-923

@mwestphal mwestphal merged commit 06783c5 into f3d-app:master Jul 12, 2025
159 of 160 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants