Skip to content

Conversation

yicheny
Copy link

@yicheny yicheny commented Dec 6, 2022

Currently, webpack5 caching is not working

If the cache was in effect, it would generate files with a '.pack' suffix, like :

rs5-has-cache

And now, the generated result looks like this:

rs5-no-cache

The reason is that 'compiler.close()' is not called

webpack will generate the cache in 'compiler.close()'

Run 'npm run build' to verify the effect

has a huge impact on compilation speed in a project

@facebook-github-bot
Copy link

Hi @yicheny!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@yicheny yicheny force-pushed the fix_webpack5_cache_invalidation branch from 0a42b5f to d239102 Compare December 6, 2022 13:54
@yicheny yicheny force-pushed the fix_webpack5_cache_invalidation branch from d239102 to 7cd017e Compare December 6, 2022 14:01
@yicheny yicheny closed this Dec 6, 2022
@yicheny
Copy link
Author

yicheny commented Dec 6, 2022

Did not join CLA at that time, so close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants