Skip to content

Conversation

skoging
Copy link
Contributor

@skoging skoging commented Apr 22, 2020

Closes #8875

Changed to babel preset env corejs option to '3.5' to match the version that react-app-polyfill depends on, as recommended by core-js.

@skoging skoging changed the title Patch 2 Change preset-env corejs version to '3.5' Apr 22, 2020
@Mrman
Copy link

Mrman commented May 8, 2020

Closes #8779 too

@Mrman
Copy link

Mrman commented May 13, 2020

Hi @ianschmitz, if this conflict were to be resolved what's the chance of getting this merged and released with 4.0.0?

@ianschmitz
Copy link
Contributor

The tricky thing about this is there are many projects beyond ours that use this preset. We don't know which minor of core-js they have installed. We could resolve the package and inspect its version, but this wouldn't be foolproof as there could by various versions of the package within the dependency graph.

@Mrman
Copy link

Mrman commented May 14, 2020

Makes sense. Could the breaking change be mitigated if this were a major version release of babel-preset-react-app?

@ianschmitz
Copy link
Contributor

We could potentially do that. We would likely want to also specify a minimum version of core-js in peerDependencies. We should have likely already been doing that. Probably just an oversight.

@Mrman
Copy link

Mrman commented May 16, 2020

I've opened a PR with the peer dependency included but have some observations and questions. They're on the PR: #9021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stable ES features are not always polyfilled when needed

4 participants