forked from containerd/nerdctl
-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] main from containerd:main #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pull
wants to merge
199
commits into
fahedouch:main
Choose a base branch
from
containerd:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akihiro Suda <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Bumps [github.com/vishvananda/netlink](https://github.com/vishvananda/netlink) from 1.3.1-0.20250303224720-0e7078ed04c8 to 1.3.1. - [Release notes](https://github.com/vishvananda/netlink/releases) - [Commits](https://github.com/vishvananda/netlink/commits/v1.3.1) --- updated-dependencies: - dependency-name: github.com/vishvananda/netlink dependency-version: 1.3.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: fahed dorgaa <[email protected]>
Signed-off-by: fahed dorgaa <[email protected]>
[CI]: carry a copy of vagrant gpg key
Signed-off-by: zhaixiaojuan <[email protected]>
Signed-off-by: fahed dorgaa <[email protected]>
….com/vishvananda/netlink-1.3.1 build(deps): bump github.com/vishvananda/netlink from 1.3.1-0.20250303224720-0e7078ed04c8 to 1.3.1
[CI]: pin docker to a specific version
[CI]: fix flaky diff test
[DOC]: clarify corner case on Tigron WithFeeder
[FIX] CNIEnv concurrency issue
Add loong64 support
fix: remove trailing newline from log entries on last decode iteration
Signed-off-by: apostasie <[email protected]>
Add loong64 as target for job-build + completion
A preparation toward fixing issue 4241 Signed-off-by: Akihiro Suda <[email protected]>
Fix issue 4241 Signed-off-by: Akihiro Suda <[email protected]>
Dockerfile: fix cross-compiling gomodjail
Signed-off-by: Subash Kotha <[email protected]>
feat: add --no-stdin flag to container attach
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Reorganize `ImageConvertOptions` by extracting format-specific options into dedicated structs (EstargzOptions, ZstdOptions, ZstdChunkedOptions, NydusOptions, OverlaybdOptions) and embedding them for better code organization and maintainability. Signed-off-by: ChengyuZhu6 <[email protected]>
[CI] Build examples
[CI] Kube test: wait for image
…ommit support estargz conversion with writable layer in container commit Fixes: #4351 Signed-off-by: ChengyuZhu6 <[email protected]>
Signed-off-by: Justin Alvarez <[email protected]>
Signed-off-by: apostasie <[email protected]>
[CI] Update registry testing tooling
commit: Add support for converting writable layers to eStargz blobs
Simplify healthcheck file handling + fix locking
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
[CI]: fix healthcheck test delay
[CI] Add delay for windows network test
refactor: move BUILDKIT_HOST to buildkitutil
Suppose we have a compose.yaml that allocates a large numbers of ports as follows. ``` > cat compose.yaml services: svc0: image: alpine command: "sleep infinity" ports: - '32000-32060:32000-32060' ``` When we run `nerdctl compose up -d` using this compose.yaml, we will get the following error. ``` FATA[0000] create container failed validation: containers.Labels: label key and value length (4711 bytes) greater than maximum size (4096 bytes), key: nerdctl/ports: invalid argument FATA[0000] error while creating container haytok-svc0-1: error while creating container haytok-svc0-1: exit status 1 ``` This issue is reported in the following issue. - #4027 This issue is considered to be the same as the one with errors when trying to perform many port mappings, such as `nerdctl run -p 80:80 -p 81:81 ~ -p 1000:1000 ...` The current implementation is processing to create a container with the information specified in -p to the label. And as can be seen from the error message, as the number of ports to be port mapped increases, the creation of the container fails because it violates the limit of the maximum number of bytes on the containerd side that can be allocated for a label. Therefore, this PR modifies the container creation process so that containers can be launched without having to assign the information specified in the -p option to the labels. Specifically, port mapping information is stored in the following path, and when port mapping information is required, it is retrieved from this file. ``` <DATAROOT>/<ADDRHASH>/containers/<NAMESPACE>/<CID>/network-config.json ``` Signed-off-by: Hayato Kiwata <[email protected]>
Signed-off-by: Hayato Kiwata <[email protected]>
[CI] Cleanup TestImageHistory
[CI] Fix broken image ref parsing and hard-coded data in tests
In case of error during write, the destination is being removed (before being possibly restored). This may lead to certain (failure) scenarios where the inode would change, effectively breaking container mounted files. Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
[CI]: rewrite compose test
Signed-off-by: apostasie <[email protected]>
fix: allow containers to start using a large numbers of ports
Bumps the docker group with 2 updates: [github.com/docker/cli](https://github.com/docker/cli) and [github.com/docker/docker](https://github.com/docker/docker). Updates `github.com/docker/cli` from 28.2.2+incompatible to 28.3.0+incompatible - [Commits](docker/cli@v28.2.2...v28.3.0) Updates `github.com/docker/docker` from 28.2.2+incompatible to 28.3.0+incompatible - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v28.2.2...v28.3.0) --- updated-dependencies: - dependency-name: github.com/docker/cli dependency-version: 28.3.0+incompatible dependency-type: direct:production update-type: version-update:semver-minor dependency-group: docker - dependency-name: github.com/docker/docker dependency-version: 28.3.0+incompatible dependency-type: direct:production update-type: version-update:semver-minor dependency-group: docker ... Signed-off-by: dependabot[bot] <[email protected]>
…-5b59b55a2a build(deps): bump the docker group with 2 updates
Hardening: internal/filesystem: prevent inode change on failure
Allow compose exec concurrency
[CI]: make healthcheck tests easier to debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )