Skip to content

feat(locale): add word data to pt_br locales #3531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: next
Choose a base branch
from

Conversation

DanielShvarts2004
Copy link

Resolves #3521

@DanielShvarts2004 DanielShvarts2004 requested a review from a team as a code owner June 19, 2025 14:09
Copy link

netlify bot commented Jun 19, 2025

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c8f140f
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/68544e75f9346200085918f6
😎 Deploy Preview https://deploy-preview-3531.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@xDivisionByZerox xDivisionByZerox added c: feature Request for new feature p: 1-normal Nothing urgent c: locale Permutes locale definitions m: word Something is referring to the word module labels Jun 19, 2025
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Jun 19, 2025
@DanielShvarts2004 DanielShvarts2004 changed the title Feature/add word data to pt br Feat/add word data to pt br Jun 19, 2025
@xDivisionByZerox
Copy link
Member

Hi @DanielShvarts2004 👋
First, let me thank you for your contribution.

The tests in the pipeline are failing, because the locale data you provided contain duplicate values. Can you remove them?
Also, your PR titles does currently not follow our guidelines. Please have a look at our CONTRIBUTING guidelines for more information.

If you need help with anything, feel free to ask :)

@DanielShvarts2004 DanielShvarts2004 changed the title Feat/add word data to pt br feat: add word data to pt_br locales Jun 19, 2025
@DanielShvarts2004
Copy link
Author

Hey thank you for your helpful response 🙏
Just fixed the dups and the title .

Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (ca58b0c) to head (c8f140f).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3531      +/-   ##
==========================================
- Coverage   99.97%   99.97%   -0.01%     
==========================================
  Files        2880     2884       +4     
  Lines      220510   221311     +801     
  Branches      952      951       -1     
==========================================
+ Hits       220457   221256     +799     
- Misses         53       55       +2     
Files with missing lines Coverage Δ
src/locales/pt_BR/index.ts 100.00% <100.00%> (ø)
src/locales/pt_BR/word/adjective.ts 100.00% <100.00%> (ø)
src/locales/pt_BR/word/index.ts 100.00% <100.00%> (ø)
src/locales/pt_BR/word/noun.ts 100.00% <100.00%> (ø)
src/locales/pt_BR/word/verb.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes itself look fine. Would you be able to sort the list alphabetically? 🙂

We already introduced sorting in some locale data, but not in the work module so far. By sorting the data now you'd help us reduce the potential diff when we introduce the normalization later this year.

@xDivisionByZerox xDivisionByZerox modified the milestones: vAnytime, v9.x Jun 19, 2025
@xDivisionByZerox xDivisionByZerox changed the title feat: add word data to pt_br locales feat(locale): add word data to pt_br locales Jun 19, 2025
@DanielShvarts2004
Copy link
Author

Of course! Love the idea

@matthewmayer
Copy link
Contributor

I don't know how similar pt_PT and pt_BR are. Could we use the same word lists for pt_PT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature c: locale Permutes locale definitions m: word Something is referring to the word module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing 'word.adjective' locale data in 'pt_BR' breaks internet.domainName()
4 participants