-
-
Notifications
You must be signed in to change notification settings - Fork 981
feat(locale): add word data to pt_br locales #3531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
feat(locale): add word data to pt_br locales #3531
Conversation
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hi @DanielShvarts2004 👋 The tests in the pipeline are failing, because the locale data you provided contain duplicate values. Can you remove them? If you need help with anything, feel free to ask :) |
Hey thank you for your helpful response 🙏 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3531 +/- ##
==========================================
- Coverage 99.97% 99.97% -0.01%
==========================================
Files 2880 2884 +4
Lines 220510 221311 +801
Branches 952 951 -1
==========================================
+ Hits 220457 221256 +799
- Misses 53 55 +2
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes itself look fine. Would you be able to sort the list alphabetically? 🙂
We already introduced sorting in some locale data, but not in the work module so far. By sorting the data now you'd help us reduce the potential diff when we introduce the normalization later this year.
Of course! Love the idea |
I don't know how similar pt_PT and pt_BR are. Could we use the same word lists for pt_PT? |
Resolves #3521