wip

Author: morganchen12

functions/src/github.ts

@@ -273,33 +273,35 @@ async function paginate<S extends PageParams, T>(
   fn: GitHubFn<S, Array<T>>,
   options: S
 ): Promise<T[]> {
-  const per_page = 100;
-  let pagesRemaining = true;
-  let page = 0;
-
-  let allData = [] as T[];
-  while (pagesRemaining) {
-    page++;
-
-    // Merge pagination options with the options passed in
-    const pageOptions = Object.assign(
-      {
-        per_page,
-        page
-      },
-      options
-    );
-
-    const res = await fn(pageOptions);
-    allData = allData.concat(res.data);
-
-    // We assume another page remaining if we got exactly as many
-    // issues as we asked for.
-    pagesRemaining = res.data.length == per_page;
-
-    // Wait 0.5s between pages
-    await util.delay(0.5);
-  }
+  return this.api.paginate(options);
+
+  // const per_page = 100;
+  // let pagesRemaining = true;
+  // let page = 0;
+
+  // let allData = [] as T[];
+  // while (pagesRemaining) {
+  //   page++;
+
+  //   // Merge pagination options with the options passed in
+  //   const pageOptions = Object.assign(
+  //     {
+  //       per_page,
+  //       page
+  //     },
+  //     options
+  //   );
+
+  //   const res = await fn(pageOptions);
+  //   allData = allData.concat(res.data);
+
+  //   // We assume another page remaining if we got exactly as many
+  //   // issues as we asked for.
+  //   pagesRemaining = res.data.length == per_page;
+
+  //   // Wait 0.5s between pages
+  //   await util.delay(0.5);
+  // }
 
-  return allData;
+  // return allData;
 }

functions/src/issues.ts

@@ -241,59 +241,6 @@ export class IssueHandler {
       actions.push(...this.markNeedsTriage(repo, issue));
     }
 
-    // Filter spam from b/378634578. This can be removed in the future.
-    const spamWords = [
-      "pemain",
-      "paybis",
-      "cracked version",
-      "xnxx",
-      "sex@videos",
-      "inatogel",
-      "ao vivo",
-      ["cracktel.com"],
-      ["therealhax.net"],
-      ["## [", "download", "/dl/"],
-      ["changelly", "crypto"],
-      ["telegram leak"],
-      ["call +1", "contact"],
-      ["safepal", "support"],
-      ["recover", "account", "1-866-"],
-      ["1-866-409-9289"],
-      ["robinhood", "support"],
-      ["blockchain", "support"],
-      ["blogspot.com"],
-      ["wordpress.com/wp-content"],
-      ["situs", "slot"],
-      ["jogos", "direto"],
-      ["jogos", "directo"],
-      ["video viral", "x twitter"]
-    ];
-    const issueContent = ` ${issue.title} ${issue.body || ""} `.toLowerCase();
-    // Scope spam filtering to affected repos only.
-    const isAffectedRepo = org == "firebase";
-    const isSpam =
-      isAffectedRepo &&
-      spamWords.find(wordOrArray => {
-        if (Array.isArray(wordOrArray)) {
-          return wordOrArray.every(word => issueContent.includes(word));
-        } else {
-          const wordWithSpace = ` ${wordOrArray} `;
-          return issueContent.includes(wordWithSpace);
-        }
-      });
-
-    if (isSpam) {
-      // Discard other actions, wipe and lock the issue, and block
-      // the offending user.
-      const reason = `Issue is believed to be spam: ${issue.title}`;
-      // Disabled for now. Can be re-enabled if spam reoccurs in the future.
-      // return [
-      //   new types.GitHubSpamAction(org, name, issue.number, reason),
-      //   new types.GitHubBlockAction(org, issue.user.login),
-      //   new types.GitHubLockAction(org, name, issue.number)
-      // ];
-    }
-
     // Check if it matches the template. This feature is implicitly enabled by
     // the template having "matchable" structure so there is no need to check
     // the repo's configuration.

functions/src/test/stale-issues-test.ts

@@ -265,8 +265,6 @@ describe("Stale issue handler", async () => {
       DEFAULT_CONFIG
     );
 
-    console.log(actions);
-
     util.actionsListEqual(actions, [
       new types.GitHubCommentAction(
         "firebase",

functions/src/types.ts

@@ -461,7 +461,7 @@ export namespace github {
     milestone: Milestone;
     locked: boolean;
     comments: number;
-    pull_request: boolean;
+    pull_request: PullRequest;
     closed_at?: string;
     created_at: string;
     updated_at: string;