Fix CMake configuration for hide-formfields build #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `CMakeLists.txt` to properly find and link Qt5 and Poppler libraries. - Set correct include directories to resolve build issues. - Ensures compatibility and successful build on systems with Qt5 and Poppler dependencies.
|
@AlexeyNikipelau does this enable us to build this binary? Is there still a use for it? Tagging you in here |
|
We're deprecating this functionality (it wasn't really in use in any case) and have removed this library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes the CMake configuration for the
hide-formfieldsmodule, ensuring that the build works properly on systems with Qt5 and Poppler dependencies.Changes:
CMakeLists.txtto properly locate and link Qt5 and Poppler libraries.Why this change?
The previous configuration caused compatibility issues on certain systems where dependencies like Qt5 and Poppler were not properly detected or linked. This fix ensures a smooth and consistent build process across environments.