Skip to content

Utils naming/xmldoc polish #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 13, 2024
Merged

Utils naming/xmldoc polish #249

merged 7 commits into from
Apr 13, 2024

Conversation

bartelink
Copy link
Member

Minor consistency tweaks

bartelink
bartelink commented Mar 31, 2024
View reviewed changes
bartelink
bartelink commented Mar 31, 2024
View reviewed changes
bartelink
bartelink commented Mar 31, 2024
View reviewed changes
bartelink
bartelink commented Mar 31, 2024
View reviewed changes
abelbraaksma
abelbraaksma requested changes Apr 4, 2024
View reviewed changes
Copy link
Member

@abelbraaksma abelbraaksma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the keen eye on the details!

A few nitpicks, no blockers though.

abelbraaksma
abelbraaksma reviewed Apr 6, 2024
View reviewed changes
@bartelink bartelink requested a review from abelbraaksma April 6, 2024 20:25
abelbraaksma
abelbraaksma approved these changes Apr 13, 2024
View reviewed changes
Copy link
Member

@abelbraaksma abelbraaksma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

I think this is all good. If you can rebase & commit your latest suggestion, then this can be merged (no need for re-review).

@abelbraaksma
Copy link
Member

That was quick! 😆

@abelbraaksma
Copy link
Member

Thanks for all these improvements. Merging 💯.

@abelbraaksma abelbraaksma merged commit f6ff7ab into fsprojects:main Apr 13, 2024
@bartelink bartelink deleted the util-doc branch April 13, 2024 14:04
@abelbraaksma abelbraaksma added refactoring Cleanup, refactoring and minor fixes cleanup topic: task-ex Related to the proposed new TaskEx library, which should get its own oss haven labels Apr 15, 2024
@abelbraaksma abelbraaksma added this to the v0.4.1 milestone May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abelbraaksma abelbraaksma abelbraaksma approved these changes

Assignees
No one assigned
Labels
cleanup refactoring Cleanup, refactoring and minor fixes topic: task-ex Related to the proposed new TaskEx library, which should get its own oss haven
Projects
None yet
Milestone
v0.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@bartelink @abelbraaksma