-
-
Notifications
You must be signed in to change notification settings - Fork 280
Improve debugging experience via UnmockedError and logging
#419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@httpretty.activate(verbose=True) httpretty.enable(verbose.True) etc. Another option is to set the logger level manually import logging from httpretty.core import logger logger.setLevel(logging.DEBUG)
sauloperez
approved these changes
May 12, 2021
sauloperez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That solves my use case 👌
Owner
Author
|
@sauloperez I'm happy to hear that. I'll just add some more tests and documentation and should make a new minor release today or tomorrow. |
|
Perfect! I appreciate it very much.
El dc., 12 de maig 2021, 12:58, Gabriel Falcão ***@***.***>
va escriure:
… @sauloperez <https://github.com/sauloperez> I'm happy to hear that. I'll
just add some more tests and documentation and should make a new minor
release today or tomorrow.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#419 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAF2B2AZMMBS2W44IBO7I23TNJNONANCNFSM44XMSPWA>
.
|
TheRealFalcon
added a commit
to TheRealFalcon/cloud-init
that referenced
this pull request
May 13, 2021
Httpretty now logs all requests by default which gets mixed up with our logging tests. Also we were incorrectly setting a logging level to 'None', which now also causes issues with the new httpretty version. See gabrielfalcao/HTTPretty#419
OddBloke
pushed a commit
to canonical/cloud-init
that referenced
this pull request
May 14, 2021
httpretty now logs all requests by default which gets mixed up with our logging tests. Also we were incorrectly setting a logging level to 'None', which now also causes issues with the new httpretty version. See gabrielfalcao/HTTPretty#419
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a proposed solution for #388
Main Changes
new properties added to
HTTPrettyRequestrequest.path- stringrequest.url- stringrequest.host- stringrequest.method- stringrequest.protocol- stringDisplay URL and other HTTP request metadata in
UnmockedErrorwhenever possiblelog every http request that was captured
httpretty.coreloggerverboseboolean argument of API triggers and decorators