ci: provide arm64 image build #83907

aldy505 · 2025-01-23T11:19:16Z

See the GHA results here: https://github.com/getsentry/sentry/actions/runs/12928078209?pr=83907

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Based on the Sentry-ARM commit: getsentry@0572d2f Co-authored-by: Vita Chumakova <[email protected]>

aldy505 · 2025-01-24T01:58:27Z

Ping so this won't get lost @hubertdeng123 @BYK @bc-sentry

BYK · 2025-01-25T16:50:58Z

Since we are exclusively on Docker Compose 2 now, I think we should use this as an opportunity to get rid of gosu and tini. For tini, we can just use the init parameter: https://stackoverflow.com/a/50357065/90297

And guessing for gosu we just need to set user on the image or something?

bc-sentry

@aldy505 While arm64 runners are in beta, the global pool of runners is severely constrained and will result in job queuing. We would like to wait to add the arm64 image until runners is prod and sufficient capacity exists. Thanks.

asottile-sentry · 2025-01-27T16:15:22Z

Since we are exclusively on Docker Compose 2 now, I think we should use this as an opportunity to get rid of gosu and tini. For tini, we can just use the init parameter: https://stackoverflow.com/a/50357065/90297

And guessing for gosu we just need to set user on the image or something?

slightly easier patch woudl be to install them from apt instead of curl anyway

bc-sentry · 2025-01-27T20:28:20Z

@aldy505 While arm64 runners are in beta, the global pool of runners is severely constrained and will result in job queuing. We would like to wait to add the arm64 image until runners is prod and sufficient capacity exists. Thanks.

asottile-sentry · 2025-01-30T16:30:38Z

.github/workflows/self-hosted.yml

-      - run: docker login --username '${{ github.actor }}' --password-stdin ghcr.io <<< "$GHCR_TOKEN"
-        env:
-          GHCR_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        if: github.event_name != 'pull_request'
+      - run: docker login --username '${{ github.actor }}' --password '${{ github.token }}' ghcr.io
+        if: github.ref_name == 'master' && github.event_name != 'pull_request'


don't change things that are unnecessary to change. for instance this is worse than before since the password ends up in pslogs and you get a new warning

BYK · 2025-06-12T15:12:53Z

.github/workflows/self-hosted.yml

+  publish-dockerhub:
+    needs: [assemble]
+    runs-on: ubuntu-latest
+    if: ${{ (github.ref_name == 'master') }}


No pull_request limitation?

No need, the assemble itself already has this guard:

if: ${{ github.ref_name == 'master' && github.event_name != 'pull_request' }}

Then why this check at all?

Double guard :)

Err, no please. Either have it full or none. No in between stuff.

BYK

Have 2 questions, other than that this looks good!

We should probably extract the cross-arch build stuff into its own action as we keep repeating the same pattern across repos at this point.

.github/workflows/self-hosted.yml

BYK · 2025-06-12T15:14:25Z

self-hosted/Dockerfile

  && chmod +x /usr/local/bin/tini \
  && apt-get purge -y --auto-remove $buildDeps

+SHELL ["/bin/sh", "-c"]


Do we need this?

This was taken from here master...Sentry-ARM:sentry:arm64

cc @ezhevita

No, it's not necessary, I've added this to restore the default shell just to be safe, in practice there should be no behavioural differences and you should be able to run the rest of the dockerfile in bash

.github/workflows/self-hosted.yml

Very old review. Will revert or limit if arm64 runners become and issue.

In order to make #83907 works, we met a failing PR caused by rspack. The issue is here (web-infra-dev/rspack#10118), and it's fixed since 1.3.11. I'm bumping it to 1.3.15 just to make it as latest as possible. ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Follow up to #83907

hubertdeng123 · 2025-06-16T18:43:56Z

.github/workflows/self-hosted.yml

@@ -19,8 +19,17 @@ env:

 jobs:
  self-hosted:
-    runs-on: ubuntu-latest


I believe this change is causing ci builds to fail for the 25.6.0 release:
https://github.com/getsentry/publish/actions/runs/15688973336/job/44199206790

followed up #93640

Seen here: https://github.com/getsentry/publish/actions/runs/15688973336/job/44199206790 Seems to be from #83907

Follow up to #83907 publish is still failing: https://github.com/getsentry/publish/actions/runs/15717244959/job/44289929012

In order to make #83907 works, we met a failing PR caused by rspack. The issue is here (web-infra-dev/rspack#10118), and it's fixed since 1.3.11. I'm bumping it to 1.3.15 just to make it as latest as possible. ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Effort for getsentry/self-hosted#1585 See the GHA results here: https://github.com/getsentry/sentry/actions/runs/12928078209?pr=83907 ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. --------- Co-authored-by: Vita Chumakova <[email protected]> Co-authored-by: Burak Yigit Kaya <[email protected]>

Follow up to #83907

Seen here: https://github.com/getsentry/publish/actions/runs/15688973336/job/44199206790 Seems to be from #83907

In order to make #83907 works, we met a failing PR caused by rspack. The issue is here (web-infra-dev/rspack#10118), and it's fixed since 1.3.11. I'm bumping it to 1.3.15 just to make it as latest as possible. ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Effort for getsentry/self-hosted#1585 See the GHA results here: https://github.com/getsentry/sentry/actions/runs/12928078209?pr=83907 ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. --------- Co-authored-by: Vita Chumakova <[email protected]> Co-authored-by: Burak Yigit Kaya <[email protected]>

Follow up to #83907

Seen here: https://github.com/getsentry/publish/actions/runs/15688973336/job/44199206790 Seems to be from #83907

Follow up to #83907 publish is still failing: https://github.com/getsentry/publish/actions/runs/15717244959/job/44289929012

aldy505 and others added 3 commits January 23, 2025 18:05

build: download arm64 version of gosu and tini

4f4d69e

Based on the Sentry-ARM commit: getsentry@0572d2f Co-authored-by: Vita Chumakova <[email protected]>

ci: build arm64 image with github arm runners

a149bfb

ci: move dockerhub publishing after image built

18a452c

aldy505 requested review from a team as code owners January 23, 2025 11:19

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 23, 2025

kahest mentioned this pull request Jan 23, 2025

sentry-native crashpad build fails on Linux arm64: arm64 does not support xpaclri getsentry/sentry-native#1123

Closed

3 tasks

aldy505 mentioned this pull request Jan 24, 2025

Support ARM64 getsentry/self-hosted#1585

Open

BYK requested a review from asottile-sentry January 25, 2025 16:50

bc-sentry previously requested changes Jan 27, 2025

View reviewed changes

ci: use similar approach with other repositories

f056374

asottile-sentry reviewed Jan 30, 2025

View reviewed changes

getsantry bot added Stale and removed Stale labels Jun 6, 2025

aldy505 and others added 3 commits June 12, 2025 21:55

Merge branch 'master' into feat/build-arm64-image

0dd270f

ci: pass docker tarball between jobs

b383241

Merge branch 'master' into feat/build-arm64-image

c8cdda8

vercel bot deployed to Preview June 12, 2025 15:11 View deployment

BYK reviewed Jun 12, 2025

View reviewed changes

BYK requested changes Jun 12, 2025

View reviewed changes

aldy505 added 3 commits June 12, 2025 22:24

ci: pre-commit schema lint

aa9ec5a

chore: prettier issue

b5651cb

ci: specify dockerfile path

dfb63e3

aldy505 commented Jun 12, 2025

View reviewed changes

.github/workflows/self-hosted.yml Outdated Show resolved Hide resolved

aldy505 added 2 commits June 12, 2025 22:52

Update self-hosted.yml

146ae51

Merge branch 'master' into feat/build-arm64-image

068a106

Merge branch 'master' into feat/build-arm64-image

36faf54

BYK approved these changes Jun 12, 2025

View reviewed changes

BYK added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Jun 12, 2025

BYK requested a review from bc-sentry June 12, 2025 22:24

aldy505 mentioned this pull request Jun 13, 2025

chore: bump rspack version #93491

Merged

Merge branch 'master' into feat/build-arm64-image

38edfad

github-actions bot removed the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Jun 13, 2025

BYK added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Jun 13, 2025

BYK enabled auto-merge (squash) June 13, 2025 11:14

BYK merged commit cbd9c9a into getsentry:master Jun 13, 2025
30 of 34 checks passed

vercel bot deployed to Preview June 13, 2025 11:15 View deployment

BYK added a commit that referenced this pull request Jun 13, 2025

ci: Fix self-hosted build

3d34c97

Follow up to #83907

BYK mentioned this pull request Jun 13, 2025

ci: Fix self-hosted build #93498

Merged

BYK added a commit that referenced this pull request Jun 13, 2025

ci: Fix self-hosted build (#93498)

fe8b5a7

Follow up to #83907

hubertdeng123 reviewed Jun 16, 2025

View reviewed changes

hubertdeng123 mentioned this pull request Jun 16, 2025

fix(self-hosted): Self-hosted release uses wrong workflow name #93640

Merged

hubertdeng123 added a commit that referenced this pull request Jun 16, 2025

fix(self-hosted): Self-hosted release uses wrong workflow name (#93640)

d52c254

Seen here: https://github.com/getsentry/publish/actions/runs/15688973336/job/44199206790 Seems to be from #83907

hubertdeng123 mentioned this pull request Jun 17, 2025

fix(release): Publish image on release branches #93757

Merged

BYK pushed a commit that referenced this pull request Jun 18, 2025

fix(release): Publish image on release branches (#93757)

6a90e0c

Follow up to #83907 publish is still failing: https://github.com/getsentry/publish/actions/runs/15717244959/job/44289929012

billyvg pushed a commit that referenced this pull request Jun 18, 2025

ci: Fix self-hosted build (#93498)

6c110c5

Follow up to #83907

billyvg pushed a commit that referenced this pull request Jun 18, 2025

fix(self-hosted): Self-hosted release uses wrong workflow name (#93640)

6475690

Seen here: https://github.com/getsentry/publish/actions/runs/15688973336/job/44199206790 Seems to be from #83907

andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025

ci: Fix self-hosted build (#93498)

e0b1e97

Follow up to #83907

andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025

fix(self-hosted): Self-hosted release uses wrong workflow name (#93640)

6dd7e4f

Seen here: https://github.com/getsentry/publish/actions/runs/15688973336/job/44199206790 Seems to be from #83907

andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025

fix(release): Publish image on release branches (#93757)

416a4ae

Follow up to #83907 publish is still failing: https://github.com/getsentry/publish/actions/runs/15717244959/job/44289929012

Uh oh!

ci: provide arm64 image build #83907

ci: provide arm64 image build #83907

Uh oh!

Conversation

aldy505 commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Legal Boilerplate

Uh oh!

aldy505 commented Jan 24, 2025

Uh oh!

BYK commented Jan 25, 2025

Uh oh!

bc-sentry left a comment

Choose a reason for hiding this comment

Uh oh!

asottile-sentry commented Jan 27, 2025

Uh oh!

bc-sentry commented Jan 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BYK left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ezhevita Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aldy505 commented Jan 23, 2025 •

edited

Loading

ezhevita Jun 12, 2025 •

edited

Loading