feat(ci): tag GHCR image with release version #88181
Conversation
There was a problem hiding this comment.
This should be done in Craft.
Kind of similar to getsentry/vroom#576 (comment)
|
@asottile-sentry do you think it's possible to publish the image (long SHA + short SHA + nightly + tagged release) as |
maybe? is there a strong reason to rename it -- it'd probably be easier to just leave it as-is also I don't think we need the |
If you've seen getsentry/self-hosted#3593, it'll be easier if we can just say "if you have a problem with DockerHub, prepend |
This is not correct, at least in terms of self-hosted releases. There |
I never see anyone using the |
Yes but I don't think that gives you the freedom to change it willy-nilly and break people's expectations? 😅 |
|
So.. what do you think? @asottile-sentry |
|
.....anything? @asottile-sentry @hubertdeng123 |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Similar work with these PRs: - getsentry/relay#4532 - getsentry/symbolicator#1635 - getsentry/snuba#6997 - getsentry/sentry#88181 While also trying to provide a solution (or at least an alternative) for this issue: getsentry/self-hosted#3593 ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
BYK
added
the
Trigger: getsentry tests
Similar work with these PRs: - getsentry/relay#4532 - getsentry/symbolicator#1635 - getsentry/snuba#6997 While also trying to provide a solution (or at least an alternative) for this issue: getsentry/self-hosted#3593 ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. --------- Co-authored-by: Burak Yigit Kaya <[email protected]>
Similar work with these PRs: - getsentry/relay#4532 - getsentry/symbolicator#1635 - getsentry/snuba#6997 While also trying to provide a solution (or at least an alternative) for this issue: getsentry/self-hosted#3593 ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. --------- Co-authored-by: Burak Yigit Kaya <[email protected]>
Similar work with these PRs:
While also trying to provide a solution (or at least an alternative) for this issue: getsentry/self-hosted#3593
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.